Hi Eric,

On 15/07/2024 16:43, e...@baculasystems.com wrote:
Hello Iyán,

Le 15 juil. 2024 à 10:56, Iyán Méndez Veiga via Bacula-devel 
<bacula-devel@lists.sourceforge.net> a écrit :

Hello,

I tried to create an issue directly in your GitLab instance, but an account is 
required and when I tried to register I never recieved the confirmation email.


Thanks for the feedback, I will double check.


There is a problem in current release 15.0.2 when the system supports zstd but 
not lzo.

compress_len and real_compress_len are defined in an ifdef HAVE_LZO block 
(l.1327), but later used in an ifdef HAVE_ZSTD (l. 1385). This causes the 
following build error:

restore.c: In function ‘bool decompress_data(JCR*, int32_t, char**, 
u_int32_t*)’:
restore.c:1387:13: error: ‘compress_len’ was not declared in this scope; did 
you mean ‘comp_len’?
  1387 |             compress_len = jcr->compress_buf_size;
       |             ^~~~~~~~~~~~
       |             comp_len
restore.c:1388:13: error: ‘cbuf’ was not declared in this scope
  1388 |             cbuf = (const unsigned char*)*data + 
sizeof(comp_stream_header);
       |             ^~~~
Compiling bxattr.c
restore.c:1389:13: error: ‘real_compress_len’ was not declared in this scope
  1389 |             real_compress_len = *length - sizeof(comp_stream_header);
       |             ^~~~~~~~~~~~~~~~~
make[1]: *** [Makefile:187: restore.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/build/bacula-client/src/bacula-15.0.2/src/filed'

I attach the full build logs.

Another thing I noticed is that latest version button in sourceforge.net still 
points to 13.x instead of 15.x. Is 15.0.2 still considered a beta? If so, it 
was marked as Release in GitLab tags.


No, 15.0.2 is the stable release, I thought I did the change, thanks for the 
heads up. I have pushed a fix in the git repository.

https://gitlab.bacula.org/bacula-community-edition/bacula-community/-/commit/c18d2ee1b1743facc057ee9e3ee9bfbd63299a64

Great, thanks! I applied the patch and it builds without issues.

Also, I can see that sourceforge.net now shows the correct version. In any case, I replace this hacky command: curl -I https://sourceforge.net/projects/bacula/files/latest/download | grep -m 1 location | cut -d "/" -f 7

With simply checking the latest GitLab tag that starts with Release- ;)


Thanks,

Best Regards,
Eric

Best regards,
Iyán

--
Iyán Méndez Veiga
GPG 0x422E3694311E5AC1

<build-logs-bacula-15.0.2.txt>_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel


Best,
Iyán

--
Iyán Méndez Veiga
GPG 0x422E3694311E5AC1

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel

Reply via email to