On 02/17/12 09:50 AM, Silver Salonen wrote: > > > Well, I plan to do some more work on usability besides sorting, so I suspect > I might need someone to discuss some other topic in the future too. I would start describing your feature request before doing any coding. You could otherwise end up with code that will never merge upstream. Not that it should hold you from trying to add features that you need.
> > But to my mind sorting should be implemented everywhere, including eg. pools > and brestore (these are two places I use quite frequently and miss the > ability to sort). I think sorting in the mediaview is more then enough I guess when you talk about sorting pools you are talking about the storage pane in which sorting for me makes no sense when you have a autoloader and double click on the storage you get the content of the autoloader and you can sort any field there. The tree view doesn't really have any interesting sorting options you also have to take into consideration that you only want to sort certain rows e.g. only the ones with a volume not the autoloader lines etc. Next to that the storage tree is mostly there to get a fast overview. > > As I undestand, it's disabled for pools, because pools tab uses QTreeWidget, > not QTableWidget and sorting correctly bytes/kbytes/Mbytes is not so trivial. > There's custom sorting code implemented also for QTableWidget, so what has to > be done, is expanding this custom code to QTreeWidget too. See above I don't see a reason to sort in the storage view when we have the better autoloader content media view. So it will be a lot of work without much gain. But if you think it will add something then feel free to try to add it but it won't be obvious giving the problems described above. As to brestore sorting, yes that might be something I think its using the standard QTableWidget stuff so its should be obvious to add sorting. e.g. tag the fields with the correct types and enable sorting in the ui. I found one sorting problem which checking what works and doesn't work currently for sorting the slot number in the media view pane. That should be sorted when 5.2.6 comes out. Marco ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel