Eric said:

> I wrote this code long time ago, and this is probably why I added this 3 
> bytes. I have to admit that we should not have this condition, so
> this extra care is probably not useful.

Proper engineering involves planning for the worst case no matter how 
unlikely. Saving the odd byte here or there doesn't usually result in 
much saving overall (real savings generally come from a new approach to 
the problem)

It would pay to add the reason for the 3 bytes extra in the preceeding 
comment to try and prevent a repeat in the distant future. :)

I have fallen victim to "That's not needed, remove it. Oh, it was 
needed" or "why did I do it that way? Oops, that's why.." on old code a 
few times.





------------------------------------------------------------------------------
Learn Windows Azure Live!  Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for 
developers. It will provide a great way to learn Windows Azure and what it 
provides. You can attend the event by watching it streamed LIVE online.  
Learn more at http://p.sf.net/sfu/ms-windowsazure
_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel

Reply via email to