SF Markus Elfring wrote: > I suggest to consider some updates for your configuration script. > http://bacula.git.sourceforge.net/git/gitweb.cgi?p=bacula/bacula;a=blob;f=bacula/autoconf/configure.in;hb=7a437be1a70b50f472d5f6e0b17daa8796908e0e > http://bacula.git.sourceforge.net/git/gitweb.cgi?p=bacula/bacula;a=blob;f=gui/autoconf/configure.in;h=9de83b09438a589dba5252202a05198139fb6936;hb=7a437be1a70b50f472d5f6e0b17daa8796908e0e > > 1. The macro "AC_PREREQ" is called too late. > > 2. The macro "AC_INIT" is called with a wrong/old parameter value. >
Wrong? That's a matter of opinion. In any case, both old and new forms will probably be supported for the indefinite future. > 3. The use of the macro "AC_CONFIG_HEADER" might be obsolete. > Might be. But it won't hurt anything if it is. > 4. I recommend to be more explicit where macro expansion will not be required. > http://autogen.sourceforge.net/acquoting.html > http://www.gnu.org/software/autoconf/manual/m4/Quoting-Arguments.html > OK. That couldn't hurt. But a new autotools release is not likely to introduce changes that would force stricter macro syntax, since it would break countless source packages. > 5. Addition of the check "AC_C_RESTRICT" > > Does Bacula even use the __restrict type qualifier for any pointers? Why would this matter? > 6. Checks are missing for the cooperation of multiple data base interfaces > (SQL engines). > > http://sourceforge.net/mailarchive/message.php?msg_name=200911100921.22773.eric%40eb.homelinux.org > > I don't think Bacula can be built with multiple databases defined anyway. > The command "autoscan" will show a couple of warnings for missing > configuration checks. Would any software developer like to fix such potential > programming errors? > > I would say they probably will not. I don't think many will see these as "potential programming errors", so fixing them would not have a very high priority on their to-do list. ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel
