On Tuesday 25 March 2008 23:56:16 Martin Simmons wrote: > >>>>> On Tue, 25 Mar 2008 17:55:50 +0100, Kern Sibbald said: > > > > As currently implemented this table is a hash table using the hash class > > that I wrote 3 or 4 years ago for this particular project. It is fast and > > efficient. > > BTW, the hash function is currently a little broken I think, e.g. these > strings will all have the same hash index: > > "abcdefghijklm" > "zzcdefghijklm" > "zzzzzzzzzzzzzzcdefghijklm"
This is normal in hash table, hash collisions always exist (even with md5, sha1, etc..), all items that have the same code are stored in a list (or a tree) Bye > The problem is that nothing collects the bits that are lost by the << > operator, so you only hash on the last 32/3 chars. I think you need to > rotate the bits instead of just shifting. > > __Martin ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel
