Hello Allan, Your patch is looking good, i will commit it shortly.
Thanks On Tuesday 04 March 2008 15:42:48 Allan Black wrote: > Kern Sibbald wrote: > > On Friday 29 February 2008 00.33:23 Allan Black wrote: > >> Eric Bollengier wrote: > >>> Good idea, but it would be much greater if this option was available in > >>> user interface (menu). Direct command line is always > >>> optional/obscure/undocumented. > > OK, I have done that, and the patch is attached. > > >>> update -> Volume -> RecyclePool > >>> 1. Default > >>> 2. Scratch > >>> 3. ... > >>> 4. *None* <---- > >> > >> [ Anyone have any preferences for where the *None* choice goes? > >> Beginning or end? :-) ] > > > > My preference is the beginning. > > And so was mine, which was why I asked in the first place :-) > > What happens with the patch applied is this: > > *up > Update choice: > 1: Volume parameters > 2: Pool from resource > 3: Slots from autochanger > Choose catalog item to update (1-3): 1 > Parameters to modify: > 1: Volume Status > 2: Volume Retention Period > 3: Volume Use Duration > 4: Maximum Volume Jobs > 5: Maximum Volume Files > 6: Maximum Volume Bytes > 7: Recycle Flag > 8: Slot > 9: InChanger Flag > 10: Volume Files > 11: Pool > 12: Volume from Pool > 13: All Volumes from Pool > 14: All Volumes from all Pools > 15: Enabled > 16: RecyclePool > 17: Done > Select parameter to modify (1-17): 16 > Defined Pools: > 1: Default > 2: Full > 3: Inc > 4: Scratch > Select the Pool (1-4): 2 > +---------+---------------+-----------+---------+----------+----------+---- >----------+---------+------+-----------+-----------+---------------------+ > > | MediaId | VolumeName | VolStatus | Enabled | VolBytes | VolFiles | > > VolRetention | Recycle | Slot | InChanger | MediaType | LastWritten > > +---------+---------------+-----------+---------+----------+----------+---- >----------+---------+------+-----------+-----------+---------------------+ > > | 1 | TestVolume001 | Append | 1 | 199 | 0 | > > 31,536,000 | 1 | 1 | 1 | DDS-4 | 0000-00-00 > 00:00:00 | > +---------+---------------+-----------+---------+----------+----------+---- >----------+---------+------+-----------+-----------+---------------------+ > Enter MediaId or Volume name: 1 > Updating Volume "TestVolume001" > No current RecyclePool > Defined Pools: > 1: *none* > 2: Default > 3: Full > 4: Inc > 5: Scratch > Select the Pool (1-5): > > The main difference here is that the prompt > Enter new RecyclePool name: > has gone and the menu of valid pools appears immediately. > > I had to remove the free-form prompt because hitting return in > response to this prompt was being interpreted as "no recyclepool", > which meant that the only way to get to the menu was deliberately > to enter an invalid pool name. (This happens because it was the > same code that interpreted both the response to the prompt, and > the recyclepool="" value.) > > Previously, you had to hit return in response to the prompt to get > the menu of pools to use as RecyclePool. > > Allan ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel
