Pete thanks for this.
BTW this represents my first contribution to the open-source effort! - it ain't much but it is a start. Peter Donald <[EMAIL PROTECTED]> on 11/12/2001 21:50:15 Please respond to "Avalon Developers List" <avalon-dev@jakarta.apache.org> To: "Avalon Developers List" <avalon-dev@jakarta.apache.org> cc: Subject: Re: Logkit: Logger.is[Priority]Enabled - suggested method. Works for me. I just committed a modified version of your suggestion - namely I used method name isPriorityEnabled(). Thanks! On Tue, 11 Dec 2001 10:40, [EMAIL PROTECTED] wrote: > I have been playing with LogKit (Playing is good). > > With the deprecation of the getPriority() method of the Logger class, a > series of is[Priority]Enabled() methods were added. > > May I suggest that 1 additional method is needed within the class and it > would look something like this: > > /** > * Determine if messages of priority will be logged. > * > * @return true if messages will be logged > */ > public final boolean isEnabled(Priority p) > { > return getPriority().isLowerOrEqual( p ); > } > > I think that this would complement the existing is[]Enabled() methods > without breaking IOC and provide a little more flexibility. > > Any comments - anyone? > > > > **************************************************************** > NOTICE - This message is intended only for the use of the > addressee named above and may contain privileged and > confidential information. If you are not the intended recipient > of this message you are hereby notified that you must not > disseminate, copy or take any action based upon it. If you > received this message in error please notify HIC immediately. > Any views expressed in this message are those of the individual > sender, except where the sender specifically states them to be > the views of HIC. > **************************************************************** -- Cheers, Pete ---------------------------------------------------------------- Fools ignore complexity. Pragmatists suffer it. Some can avoid it. Geniuses remove it. -- Perlis's Programming Proverb #58, SIGPLAN Notices, Sept. 1982 ---------------------------------------------------------------- -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED] > For additional commands, e-mail: <mailto:[EMAIL PROTECTED] > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>