This configure output

  checking whether sleep supports fractional seconds... true

is inconsistent with the rest of the GNU Build System. Namely, in
configure output, results are "yes"/"no", not "true"/"false".

The attached patch makes automake consistent with the rest.

Verified to pass "make check".

>From 43841ccedc4c0055d50df64934fc6a673d9f1551 Mon Sep 17 00:00:00 2001
From: Bruno Haible <br...@clisp.org>
Date: Tue, 2 Jul 2024 00:19:27 +0200
Subject: [PATCH] automake: Improve display of whether sleep supports
 fractional seconds.

* m4/sanity.m4 (_AM_SLEEP_FRACTIONAL_SECONDS): Set
am_cv_sleep_fractional_seconds to yes/no, not true/false.
(_AM_FILESYSTEM_TIMESTAMP_RESOLUTION): Test for yes/no.
* t/ax/test-defs.in: Set am_cv_sleep_fractional_seconds to 'no', not
'false'.
---
 m4/sanity.m4      | 6 +++---
 t/ax/test-defs.in | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/m4/sanity.m4 b/m4/sanity.m4
index 3c69f686c..dde7ecd4c 100644
--- a/m4/sanity.m4
+++ b/m4/sanity.m4
@@ -11,8 +11,8 @@
 AC_DEFUN([_AM_SLEEP_FRACTIONAL_SECONDS], [dnl
 AC_CACHE_CHECK([whether sleep supports fractional seconds],
                am_cv_sleep_fractional_seconds, [dnl
-AS_IF([sleep 0.001 2>/dev/null], [am_cv_sleep_fractional_seconds=true],
-                                 [am_cv_sleep_fractional_seconds=false])
+AS_IF([sleep 0.001 2>/dev/null], [am_cv_sleep_fractional_seconds=yes],
+                                 [am_cv_sleep_fractional_seconds=no])
 ])])
 
 # _AM_FILESYSTEM_TIMESTAMP_RESOLUTION
@@ -43,7 +43,7 @@ am_cv_filesystem_timestamp_resolution='2 sec'
 # packages.
 #
 am_try_resolutions=
-if $am_cv_sleep_fractional_seconds; then
+if test $am_cv_sleep_fractional_seconds = yes; then
   # Even a millisecond often causes a bunch of false positives,
   # so just try a hundredth of a second. The time saved between .001 and
   # .01 is not terribly consequential.
diff --git a/t/ax/test-defs.in b/t/ax/test-defs.in
index 388271cd5..1dfb83cd6 100644
--- a/t/ax/test-defs.in
+++ b/t/ax/test-defs.in
@@ -211,7 +211,7 @@ case $MTIME_RESOLUTION in
       MTIME_RESOLUTION=1
       # we must not sleep for fractional seconds when autom4te does not
       # support subsecond-mtimes, even when sleep supports it. See bug#67670.
-      am_cv_sleep_fractional_seconds=false
+      am_cv_sleep_fractional_seconds=no
       export am_cv_sleep_fractional_seconds
     fi
   ;;
@@ -232,7 +232,7 @@ esac
 # scripts in other packages, too.
 # 
 # At any rate, with this set to "sleep 1", there were still random
-# parallelization failures; setting am_cv_sleep_fractional_seconds=false
+# parallelization failures; setting am_cv_sleep_fractional_seconds=no
 # as above was still needed.
 #
 sleep="sleep $MTIME_RESOLUTION"
-- 
2.34.1

Reply via email to