Hello Bob,

On 2019-08-24 5:26 p.m., Bob Friesenhahn wrote:
On Sat, 24 Aug 2019, Assaf Gordon wrote:

hello_LDADD =  $(top_builddir)/lib/lib$(PACKAGE).a
datamash_LDADD =  $(top_builddir)/lib/lib$(PACKAGE).a

This seems like a bug in those two packages.  It should never be desirable to refer to the build directory other than by using the knowledge that the build is done using the current directory.

Why do you say so?
Is there a reference to somewhere authoritative with such recommendation?

"top_builddir" is supposed to point to the build directory,
and similarly there's "abs_top_builddir", as well as some others:
https://www.gnu.org/software/autoconf/manual/autoconf-2.63/html_node/Preset-Output-Variables.html

Why shouldn't they be used?

However,
This change (regression?) seems to come from automake, perhaps
consider a bugfix for future versions.

Unfortunately, the 'hello' program is supposed to be a reference example of the right things to do.

That,
and the fact it it was working fine for many years and automake versions is the reason I ask why do you think it should not be used.

Thanks,
 - assaf



Reply via email to