Jim Meyering <j...@meyering.net> writes: > On Mon, Nov 27, 2017 at 8:12 PM, Jim Meyering <j...@meyering.net> wrote: >> On Mon, Nov 27, 2017 at 12:52 PM, Jim Meyering <j...@meyering.net> wrote: >>> On Mon, Nov 27, 2017 at 10:27 AM, Glenn Morris <rgm+n...@gnu.org> wrote: >>>> >>>> In general, Emacs expects .el and .elc to be found in the same >>>> directory. Not adhering to this convention will likely break various >>>> Emacs features. Is this really something automake needs to enable at all? >>> >>> An alternative would be to copy-or-link the .el file into the >>> destination directory. Indeed. That would work without breaking pre-23 >>> emacs, so I will adjust my automake patch before pushing it to master. >> >> Hi Glenn, >> >> I've thought about this some more and do not like the idea of >> requiring automake's elisp-compilation rule to make a copy of the >> source file in the destination directory in this slightly contrived >> case. Remember: this arises only in a non-srcdir build. That means >> build artifacts end up being written into the mostly-empty current >> directory hierarchy, which does not have copies of the sources. >> Installation processes will continue to copy both .el and .elc files >> into place.
I don't like this idea neither. > Here is the updated (NEWS addition) patch that I expect to push to > master tomorrow. Feedback welcome. I will also delete the "micro" > branch I created. > From 7558bddcc9cf5ee14441304c2cfc7cffb566daba Mon Sep 17 00:00:00 2001 > From: Jim Meyering <meyer...@fb.com> > Date: Wed, 22 Nov 2017 21:07:29 -0800 > Subject: [PATCH] port elisp-compilation support to emacs-23.1 and newer > > In May of 2017, Emacs' support for using the long-deprecated > byte-compile-dest-file function was removed, and that removal broke > automake's elisp-compiling rule for any .el file not in the current > directory. In emacs-23.1 (July 2009) byte-compile-dest-file-function > became the recommended way to adjust the byte-compiler's destination. > We expect the removed functionality to be restored for Emacs-26, > albeit with dissuasive diagnostics warning about the imminent removal > of this functionality. It may be removed in Emacs-27. > * lib/am/lisp.am (.el.elc): Use byte-compile-dest-file-function, > rather than byte-compile-dest-file. > * t/lisp-readonly-srcdir.sh: New file, to test for the above. > * t/list-of-tests.mk (handwritten_TESTS): Add it. > * NEWS (Bugs fixed): Mention this problem. OK to push. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
