Hello, * Jim Meyering wrote on Sun, Dec 13, 2009 at 11:44:15AM CET: > Paolo Bonzini wrote: > > This rule could actually be moved to Automake's distcheck target. > > Good idea. > FYI, here's the definition I have now: > (added GPERF and LIBTOOL, and made it overridable)
Adding LIBTOOL here is wrong; you meant LIBTOOLIZE. There are several packages that would break, or at least have a less effective distcheck with this. For example, Libtool uses Autoconf and Automake tools in its new testsuite. Lots of packages build info files in the build tree only, or build HTML with makeinfo. Since currently the variable $(null_AM_MAKEFLAGS) isn't used in Automake code at all however, did you mean to move more code there? > # Use this to make sure we don't run these programs when building > # from a virgin tgz file, below. > null_AM_MAKEFLAGS ?= \ > ACLOCAL=false \ > AUTOCONF=false \ > AUTOMAKE=false \ > AUTOHEADER=false \ > GPERF=false \ > LIBTOOL=false \ > MAKEINFO=false Thanks, Ralf
