Hello Andreas,
* Andreas Schwab wrote on Wed, Apr 01, 2009 at 02:35:49PM CEST:
> I'm getting several failures in the automake testsuite, for example:
>
> FAIL: libtool.test (exit: 1)
> + aclocal-1.10b -Werror -Wno-syntax -I
> /home/andreas/src/osc/automake/BUILD/automake-1.10b/tests/../m4 -I
> /usr/local/share/aclocal -I /usr/share/aclocal
> aclocal: couldn't open directory `/usr/local/share/aclocal': No such file or
> directory
> The problem is that /usr/share/aclocal/dirlist contains the
> (non-existing) directory /usr/local/share/aclocal. Normally aclocal
> would ignore such a directory, but by adding it explicitly with -I
> aclocal now complains.
Thank you! Fixed thusly, pushed to next and branch-1-10.
Cheers,
Ralf
Fix testsuite failures due to nonexistent `dirlist' entries.
* tests/defs.in: When parsing `$aclocaldir/dirlist', only add
existing directories D to aclocal `-I D' flags, as aclocal
errors on nonexisting directories.
Report and analysis by Andreas Schwab.
diff --git a/tests/defs.in b/tests/defs.in
index aee5dfa..3193eed 100644
--- a/tests/defs.in
+++ b/tests/defs.in
@@ -320,8 +320,8 @@ case $required in
if test -f $aclocaldir/dirlist; then
extra_includes=`
<$aclocaldir/dirlist \
- sed -ne 's/#.*//;s/[ ][ ]*$//g;s/..*/ -I &/p' |
- tr -d '\n'`
+ sed 's/#.*//;s/[ ][ ]*$//g' \
+ | while read dir; do test ! -d "$dir" || echo "-I $dir"; done`
else :; fi
libtool_found=no
