Ralf Wildenhues wrote:
Hello Jason,

* Jason Curl wrote on Mon, Jul 30, 2007 at 04:06:44PM CEST:
Makefile.am
  FILES = dir1 dir2
  if BUILD_DIR3
  FILES += dir3
  fi
  SUBDIRS = $(FILES)

Then you get an error output like:
Makefile.am:19: unterminated conditionals: BUILD_DIR3_TRUE
automake-1.10: ####################
automake-1.10: ## Internal Error ##
automake-1.10: ####################
[...]

Do you think it would be more helpful if the error were like this?
| Makefile.am:4: conditional terminated with `endif' instead of `fi'

OK to apply the patch below to this end (and add Jason to THANKS)?
Looking at the patch, I can see why you've added 'fi' as a check. But does the problem remain when an 'if' is unterminated automake would still report an error? I just didn't think it was necessary to explicitly deal with "fi" except for those who get confused between sh and automake :).

But given GCC diagnostics for unterminated if's, it might be a real nightmare to do anything other than what Ralf has graciously implemented.
Cheers, and thanks,
Ralf


Reply via email to