On 2024-12-06 10:44, Zack Weinberg wrote: > I'm not sure I understand this. Could you please confirm whether the > intended semantics are that the command-line --color option overrides > NO_COLOR if both are used? And whether that is what your change > actually does?
Yes and yes. The intention of NO_COLOR is that it is a global request (for all programs) to not use terminal colours _by default_. Any specific options the user can use to enable colours (for Autotest test suites, that basically means --color, --color=auto, etc.) should still work. Essentially, for test suites, the intention is that the user should be able to reverse the effect that AT_COLOR_TESTS has on the defaults. > Would you mind sending a revised patch that also includes > documentation and a NEWS entry for this user-facing feature? OK, will do. Cheers, Nick
