-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Ralf Wildenhues on 1/28/2008 1:37 PM: | [...] |> @@ -361,31 +361,6 @@ fi |> ## ---------------------- ## |> m4_divert_pop([PREPARE_TESTS])dnl back to DEFAULTS |> |> -# Load the config file. |> -for at_file in atconfig atlocal |> -do |> - test -r $at_file || continue |> - . ./$at_file || AS_ERROR([invalid content: $at_file]) |> -done | | Isn't this an API change? It looks to me the at* files are now | interpreted after the command line (untested). That seems wrong: | the command line should override atlocal, if I do | ./testsuite PERL=/some/other/perl
Ouch. I think you're right. The problem which drove me to move this snippet was that unless atconfig lives in the same directory where you invoke testsuite, it does not get sourced, which is not what we want either (in the case of m4, it meant that running tests/testsuite did not discover the default AUTOTEST_PATH=tests in $(builddir)/tests/atconfig, and therefore, the test was being run on the installed m4 rather than the just-built m4). I guess the correct solution is to look for atconfig in the current directory (as was the case before my regression) as well as in dirname "$at_myself" (which may be the same directory), before declaring that it can't be found. I'll work on a patch along those lines. - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHnkAp84KuGfSFAYARAgMsAJ9xsVe4qblE0nwiW6mzDdEU5U+TMACeMhvi yVSPZcsjj5R5Npq7UJBvU64= =/QFq -----END PGP SIGNATURE-----
