On July 29, 2025 5:22:17 AM EDT, Amin Vakil <[email protected]> wrote: > On 7/28/25 6:31 PM, Martin Rys wrote: > > Thanks for the hints, regarding the rm -i, under which circumstances would > > makepkg propagate the alias? > > > > I tried setting it in the current shell, and the PKGBUILD worked fine for > > me with makepkg. > > Honestly I don't know under which circumstances this would be possible :) > > I've checked /etc/profile, /etc/environment, /etc/bash.bashrc and it seems > makepkg does not read alias from there, but it's better to put rm -f in all > scripts whenever they have to get run noninteractive to be on the safe side > IMHO.>
Technically avoiding `-f` would be "safer". Guarding against every unproven possibility is uneconomical. > > I believe the provides=svp in svp-bin is there as an alias, I can't find > > the original reasoning as to why I added it, though I don't believe it's > > necessarily wrong even though a real "svp" package cannot exist, as it is a > > proprietary application. > > > > svp package does not exist anymore in AUR, but the reason I'd suggest adding > a conflicts to svp-bin was to prevent installing svp and svp-bin concurrently. > > https://wiki.archlinux.org/title/PKGBUILD#provides > Packages providing the same item can be installed side-by-side, unless at > least one of them uses a conflicts array. > > > > Tampermonkey is not open source anymore. It’s released under a > > proprietary license since 2013 > > > > That's... unfortunate, looks like I'll have to switch. > > > > I have indeed mistaken it for a FOSS application, the repo is set up in a > > very poor way, making it look like the code is still open :/ > > > > On 26/07/2025 11:35, Amin Vakil wrote: > >> Hi Martin, > >> > >> Regarding your application, I had a couple of notes about some of your > >> PKGBUILDs. > >> > >> sc-controller: > >> > >> conflicts=("${pkgname}-git" 'scc') > >> There is no necessity to add -git conflicts of package, the -git package > >> should have conflicts/provides with base package. > >> > >> Unless you can use both sc-controller with sc-contoller-git and/or scc > >> package at the same time, can it? From sc-controller-git PKGBUILD it seems > >> they cannot get installed at the same time. > >> > >> svp, svp-bin: > >> Same about provides/conflicts. > >> > >> jitsi-meet-desktop-bin: > >> It has coreutils as a makedepends which is unnecessary, it's a dep of > >> util-linux which is a dep of fakeroot which is a dep of base-devel. > >> > >> It also uses rm filename in package, I think it brings problem for users > >> which alias rm to rm -i which are many. It should be rm -f IMO. > >> > >> chitubox-free-bin: > >> Same thing about rm > >> > >> Disclaimer: I'm not a PM, developer, nor ever been, just a curious arch > >> linux user for a couple of years, so feel free to ignore this in case it > >> was wrong. > >> > >> Best Regards, > >> Amin Vakil > -- Best, Daniel <https://danielcapella.com>
