Mads Jensen <[email protected]> writes: Hi Mads,
>> But there are some nitpicks wrt. fancyhdr.el. Please fix those and >> send an improved patch. >> >> - `fancyhdr-fancy-positions' is used only in one position, so no need to >> have a defvar for it. Also, if the variable was needed, it should >> have a name matching the conventions, e.g., >> `LaTeX-fancyhdr-fancy-positions'. > > Removed, and put inside the function with a suitable comment similar > to the one for the variable. Good. >> - Now that the parser supports pagestyles, you should add the fancy >> and fancyplain pagestyles provided by fancyhdr. See >> `LaTeX-add-pagestyles'. > > Yep, plainly forgot :-( Thanks for reminding me. You're welcome. >> - `TeX-arg-fancyhdr-position': The first line of the docstring should be >> one complete sentence. I suggest "Promt for a fancyhdr position." >> You should also document all arguments. Have a look at the other >> TeX-arg-* functions. > > Documented as requested. Except that you've missed the OPTIONAL argument. ;-) I've done that for you now. The changes are committed. Thanks! Bye, Tassilo _______________________________________________ auctex-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/auctex-devel
