Hi, On Fri, Oct 25, 2024 at 10:44:09AM +0300, Dan Carpenter wrote: > Hi Remi, > > kernel test robot noticed the following build warnings: > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: > https://github.com/intel-lab-lkp/linux/commits/Remi-Pommarel/wifi-ath10k-Implement-ieee80211-flush_sta-callback/20241022-172038 > base: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git ath-next > patch link: > https://lore.kernel.org/r/0f55986ebe34f2b5aa4ccbcb0bed445324099fbd.1729586267.git.repk%40triplefau.lt > patch subject: [PATCH v2 2/2] wifi: ath10k: Flush only requested txq in > ath10k_flush() > config: parisc-randconfig-r071-20241024 > (https://download.01.org/0day-ci/archive/20241025/202410251152.a5axjlir-...@intel.com/config) > compiler: hppa-linux-gcc (GCC) 14.1.0 > > If you fix the issue in a separate patch/commit (i.e. not just a new version > of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <l...@intel.com> > | Reported-by: Dan Carpenter <dan.carpen...@linaro.org> > | Closes: https://lore.kernel.org/r/202410251152.a5axjlir-...@intel.com/ > > New smatch warnings: > drivers/net/wireless/ath/ath10k/mac.c:8076 _ath10k_mac_wait_tx_complete() > error: uninitialized symbol 'empty'. > > vim +/empty +8076 drivers/net/wireless/ath/ath10k/mac.c > > c4f7022f0ef0aa Remi Pommarel 2024-10-22 8062 static void > _ath10k_mac_wait_tx_complete(struct ath10k *ar, > c4f7022f0ef0aa Remi Pommarel 2024-10-22 8063 > unsigned long queues) > 5e3dd157d7e70f Kalle Valo 2013-06-12 8064 { > affd321733eebc Michal Kazior 2013-07-16 8065 bool skip; > d4298a3a8c92a1 Nicholas Mc Guire 2015-06-15 8066 long time_left; > c4f7022f0ef0aa Remi Pommarel 2024-10-22 8067 unsigned int q; > 5e3dd157d7e70f Kalle Valo 2013-06-12 8068 > 5e3dd157d7e70f Kalle Valo 2013-06-12 8069 /* mac80211 doesn't > care if we really xmit queued frames or not > d6dfe25c8bb200 Marcin Rokicki 2017-02-20 8070 * we'll collect those > frames either way if we stop/delete vdevs > d6dfe25c8bb200 Marcin Rokicki 2017-02-20 8071 */ > 548db54cc1890b Michal Kazior 2013-07-05 8072 > affd321733eebc Michal Kazior 2013-07-16 8073 if (ar->state == > ATH10K_STATE_WEDGED) > 828853ac58265c Wen Gong 2018-08-28 8074 return; > affd321733eebc Michal Kazior 2013-07-16 8075 > d4298a3a8c92a1 Nicholas Mc Guire 2015-06-15 @8076 time_left = > wait_event_timeout(ar->htt.empty_tx_wq, ({ > 5e3dd157d7e70f Kalle Valo 2013-06-12 8077 bool > empty; > affd321733eebc Michal Kazior 2013-07-16 8078 > edb8236df4d042 Michal Kazior 2013-07-05 8079 > spin_lock_bh(&ar->htt.tx_lock); > c4f7022f0ef0aa Remi Pommarel 2024-10-22 8080 > for_each_set_bit(q, &queues, ar->hw->queues) { > > Smatch is concerned that there might not be any set bits. (You know that the > compiler is automatically going to ininitialize empty to false so it costs > nothing to initialize it to false explicitly and silence this warning).
Actually I think empty should be true here, if there is no queue to wait for being drained then no need to wait at all. Will send a v3 with that fixed. Thanks for the report and the analysis. -- Remi
