Mark Kettenis(mark.kette...@xs4all.nl) on 2020.04.23 22:56:17 +0200: > I put this in at some point since I couldn't get the eMMC on my > firefly-rk3399 working otherwise. But its eMMC died and on my > rockpro64 and rk3399-q7 boards things work very well without it. On > the latter board it even makes things a bit speedier: the raw read > performance goes up from 35 MB/s to 43 MB/s. > > Probably good if this was tested on the pinebook pro.
On the pinebook pro with the diff i get 38 MB/s from the eMMC, reading from rsd1c. Thats average over 10 reads. Without the diff i get only about 28 MB/s. /Benno > > ok? > > > Index: dev/fdt/sdhc_fdt.c > =================================================================== > RCS file: /cvs/src/sys/dev/fdt/sdhc_fdt.c,v > retrieving revision 1.7 > diff -u -p -r1.7 sdhc_fdt.c > --- dev/fdt/sdhc_fdt.c 21 Apr 2020 07:58:57 -0000 1.7 > +++ dev/fdt/sdhc_fdt.c 23 Apr 2020 20:51:48 -0000 > @@ -154,9 +154,6 @@ sdhc_fdt_attach(struct device *parent, s > */ > phy_enable(faa->fa_node, "phy_arasan"); > sc->sc.sc_flags |= SDHC_F_NOPWR0; > - > - /* XXX Doesn't work on Rockchip RK3399. */ > - sc->sc.sc_flags |= SDHC_F_NODDR50; > } > > if (OF_is_compatible(faa->fa_node, "brcm,bcm2711-emmc2")) >
