---------- Forwarded message --------- From: Ryan Lee <[email protected]> Date: Thu, Aug 14, 2025 at 9:59 AM Subject: Re: [PATCH] apparmor: Remove unused value To: Chandra Mohan Sundar <[email protected]>
On Wed, Aug 13, 2025 at 9:19 AM Chandra Mohan Sundar <[email protected]> wrote: > > The value "new" is being assigned to NULL but that statement does not > have effect since "new" is being overwritten in the subsequent fallback case. > > Remove the unused value. This issue was reported by coverity static > analyzer. > > Fixes: a9eb185be84e9 (apparmor: fix x_table_lookup) > Signed-off-by: Chandra Mohan Sundar <[email protected]> > --- > security/apparmor/domain.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c > index 267da82afb14..9c0c7fa8de46 100644 > --- a/security/apparmor/domain.c > +++ b/security/apparmor/domain.c > @@ -592,7 +592,6 @@ static struct aa_label *x_to_label(struct aa_profile > *profile, > if (!new || **lookupname != '&') > break; > stack = new; > - new = NULL; > fallthrough; /* to X_NAME */ > case AA_X_NAME: > if (xindex & AA_X_CHILD) > -- > 2.43.0 > > Since v2 was posted just now I'm leaving a record through this reply that this v1 is considered withdrawn. Ryan
