On Mon, Jan 27, 2025 at 9:59 PM Ryan Lee <ryan....@canonical.com> wrote: > > For the record, a previous patch that removes the sock variable was > previously accepted: > https://lists.ubuntu.com/archives/apparmor/2025-January/013449.html > (patch) and > https://lists.ubuntu.com/archives/apparmor/2025-January/013463.html > (ack from John Johansen) >
That makes sense, but imo the posted patch is still warranted -- all other debug macros (WARN_ON, VM_WARN_ON etc.) are expected to evaluate the condition. -- Mateusz Guzik <mjguzik gmail.com>