On Fri, Nov 15, 2024 at 06:17:11PM -0800, John Johansen wrote:
> thanks for the patch, but I went with an alternate version, that I did last
> Sunday
> (sorry I guess I forgot to push the tree). Since I hadn't pushed the tree I
> did
> consider replacing my patch with it but in the end decided to not go with
> the C99 variable declaration, moving the var to the top of the outer block
> (what
> my Sunday patch did).
Thanks for the information, I considered doing the same thing but went
with the minimal fix just for ease of acceptance. Appreciate you getting
this resolved now.
> The reason being that while I don't think the style guideline forbid them, I
> end
> up getting patches for them anyways, as some compiler flag sets will warn
> about
> them.
For what it's worth, commit b5ec6fd286df ("kbuild: Drop
-Wdeclaration-after-statement") dropped the option that warns about
that, so you should not have to worry about that anymore.
Cheers,
Nathan
