Hi all,

I wrote a new module that can add a variable to 'extra-vars' from within a 
play. 
All logic executes locally, so this module actually is an action plugin. 
But that also requires a 'stub' module in 'modules/core/logic'...
I verified my code against the latest 'devel' version and also ran tests 
from 'test'. No failures.
In fact, I already created a pull-request against the ansible 2.1-stable 
branch, but that PR was closed since that
stable version does not accept new features anymore. I modified my code to 
work with the latest devel branch.

so, I forked 'ansible' and 'ansible-modules-core' and commited my changes 
to my forked 'devel' branch, i.e. I committed
code to my 'devel' ansible branch, and the 'stub' module  ( dunno if this 
is correctly described.. it's like the 'set_fact' module; there
just needs to be a file for the module in 'modules/core/logic'..) to my 
ansible-modules-core fork.

Then I created two pull requests; one for 'ansible devel'  and one for 
'ansible-modules-core  devel'...
These are the same steps I took for the '2.1-stable'  PRs..   Those PR's 
were verified correctly by the Shippable tooling,
but with the 'devel' branch it fails :

  for 'ansible devel'  the console build_ci step says : 
lib/ansible/modules/extras 2016-12-08 09:43:43 
============================================================================ 
2016-12-08 09:43:43 ERROR: Ansible module subdirectories must contain an 
__init__.py 2016-12-08 09:43:43 2016-12-08 09:43:43 
============================================================================ 
2016-12-08 09:43:43 lib/ansible/modules/core 2016-12-08 09:43:43 
============================================================================ 
2016-12-08 09:43:43 ERROR: Ansible module subdirectories must contain an 
__init__.py

and for 'ansible-modules-core' the console says :

                   Logs are not available.

I think this might be caused by the split in code between 'ansible' and its 
modules...  If I look in my forked branch, then
'lib/ansible/modules'  contains the 'core' and 'extras' directories as some 
sort of links...  I don't get how this is set up..

If run the test on my local clone without anything in the 
'lib/ansible/modules/core' directories, I obviously get the
'subdirectories must contain an __init__.py'  error.  That makes sense.
But something has changed apparently, since the same PR's for 2.1-stable 
did not run into this failure..

Question is : how do I create the pull requests for this feature request ? 
    

Thanks in advance....

-- 
You received this message because you are subscribed to the Google Groups 
"Ansible Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to