[AMD Official Use Only - General] Reviewed-by: Asad Kamal <asad.ka...@amd.com<mailto:asad.ka...@amd.com>>
Thanks & Regards Asad From: Wang, Yang(Kevin) <kevinyang.w...@amd.com> Sent: Wednesday, November 15, 2023 8:42 AM To: Lazar, Lijo <lijo.la...@amd.com>; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking <hawking.zh...@amd.com>; Deucher, Alexander <alexander.deuc...@amd.com>; Kamal, Asad <asad.ka...@amd.com>; Ma, Le <le...@amd.com> Subject: Re: [PATCH] drm/amd/pm: Don't send unload message for reset [AMD Official Use Only - General] Reviewed-by: Yang Wang <kevinyang.w...@amd.com<mailto:kevinyang.w...@amd.com>> Best Regards, Kevin ________________________________ From: Lazar, Lijo <lijo.la...@amd.com<mailto:lijo.la...@amd.com>> Sent: Wednesday, November 15, 2023 11:04 To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> <amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>> Cc: Zhang, Hawking <hawking.zh...@amd.com<mailto:hawking.zh...@amd.com>>; Deucher, Alexander <alexander.deuc...@amd.com<mailto:alexander.deuc...@amd.com>>; Kamal, Asad <asad.ka...@amd.com<mailto:asad.ka...@amd.com>>; Ma, Le <le...@amd.com<mailto:le...@amd.com>>; Wang, Yang(Kevin) <kevinyang.w...@amd.com<mailto:kevinyang.w...@amd.com>> Subject: [PATCH] drm/amd/pm: Don't send unload message for reset No need to notify about unload during reset. Also remove the FW version check. Signed-off-by: Lijo Lazar <lijo.la...@amd.com<mailto:lijo.la...@amd.com>> --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c index b51cd9e50e64..d431553ad8b8 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c @@ -1500,7 +1500,7 @@ static int smu_v13_0_6_register_irq_handler(struct smu_context *smu) static int smu_v13_0_6_notify_unload(struct smu_context *smu) { - if (smu->smc_fw_version <= 0x553500) + if (amdgpu_in_reset(smu->adev)) return 0; dev_dbg(smu->adev->dev, "Notify PMFW about driver unload"); -- 2.25.1
