Re: [PATCH] drm/amd/pm: clean up redundant comparisons with 0

[Guenter Roeck]

On 11/7/23 00:29, José Pekkarinen wrote:

There is a couple of function return checks of functions that return
unsigned values, and local variables to hold them are also unsigned, so
checking if they are negative will always return false. This patch will
remove them, as well as the never reached code.

drivers/gpu/drm/amd/pm/amdgpu_pm.c:2801:5-8: WARNING: Unsigned expression compared 
with zero: val < 0
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2814:5-8: WARNING: Unsigned expression compared 
with zero: val < 0

Signed-off-by: José Pekkarinen <jose.pekkari...@foxhound.fi>
---
  drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 ----
  1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c 
b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index 8bb2da13826f..e7bb1d324084 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -2798,8 +2798,6 @@ static ssize_t amdgpu_hwmon_show_power_avg(struct device 
*dev,
        unsigned int val;

val = amdgpu_hwmon_get_power(dev, AMDGPU_PP_SENSOR_GPU_AVG_POWER);

-       if (val < 0)
-               return val;

This is reporting errors returned from amdgpu_hwmon_get_power() as large 
integers.

Guenter

        return sysfs_emit(buf, "%u\n", val);
  }
@@ -2811,8 +2809,6 @@ static ssize_t amdgpu_hwmon_show_power_input(struct 
device *dev,
        unsigned int val;

val = amdgpu_hwmon_get_power(dev, AMDGPU_PP_SENSOR_GPU_INPUT_POWER);

-       if (val < 0)
-               return val;

return sysfs_emit(buf, "%u\n", val);

  }