[AMD Official Use Only - General]
Reviewed-by: Yang Wang <kevinyang.w...@amd.com>
Best Regards,
Kevin
-----Original Message-----
From: Kunwu.Chan <chen...@kylinos.cn>
Sent: Tuesday, October 10, 2023 2:11 PM
To: Wang, Yang(Kevin) <kevinyang.w...@amd.com>
Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Kamal, Asad
<asad.ka...@amd.com>; Koenig, Christian <christian.koe...@amd.com>; Zhang,
Hawking <hawking.zh...@amd.com>; Ma, Le <le...@amd.com>; Lazar, Lijo
<lijo.la...@amd.com>; Pan, Xinhui <xinhui....@amd.com>; airl...@gmail.com;
amd-gfx@lists.freedesktop.org; chen...@kylinos.cn; dan.carpen...@linaro.org;
dan...@ffwll.ch; dri-de...@lists.freedesktop.org; evan.q...@amd.com;
kunwu.c...@hotmail.com; linux-ker...@vger.kernel.org
Subject: [PATCH] drm/amd/pm: Fix a memory leak on an error path
Add missing free on an error path.
Fixes: 511a95552ec8 ("drm/amd/pm: Add SMU 13.0.6 support")
Signed-off-by: Kunwu.Chan <chen...@kylinos.cn>
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
index ce971a93d28b..c26e12ff532c 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
@@ -1981,8 +1981,10 @@ static ssize_t smu_v13_0_6_get_gpu_metrics(struct
smu_context *smu, void **table
metrics = kzalloc(sizeof(MetricsTable_t), GFP_KERNEL);
ret = smu_v13_0_6_get_metrics_table(smu, metrics, true);
- if (ret)
+ if (ret) {
+ kfree(metrics);
return ret;
+ }
smu_cmn_init_soft_gpu_metrics(gpu_metrics, 1, 3);
--
2.25.1
