On 7/17/23 15:09, Michel Dänzer wrote: > On 5/10/23 23:23, Alex Deucher wrote: >> From: Philip Yang <philip.y...@amd.com> >> >> Rename smv_migrate_init to a better name kgd2kfd_init_zone_device >> because it setup zone devive pgmap for page migration and keep it in >> kfd_migrate.c to access static functions svm_migrate_pgmap_ops. Call it >> only once in amdgpu_device_ip_init after adev ip blocks are initialized, >> but before amdgpu_amdkfd_device_init initialize kfd nodes which enable >> SVM support based on pgmap. >> >> svm_range_set_max_pages is called by kgd2kfd_device_init everytime after >> switching compute partition mode. >> >> Signed-off-by: Philip Yang <philip.y...@amd.com> >> Reviewed-by: Felix Kuehling <felix.kuehl...@amd.com> >> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> > > I bisected a regression to this commit, which broke HW acceleration on this > ThinkPad E595 with Picasso APU.
Actually, it doesn't seem to break HW acceleration completely. GDM eventually comes up with HW acceleration, it takes a long time (~30s or so) to start up though. Later, the same messages as described in https://gitlab.freedesktop.org/drm/amd/-/issues/2659 appear. Reverting this commit fixes all of the above symptoms. I reproduced all of the above symptoms with amd-staging-drm-next commit 75515acf4b60 ("i2c: nvidia-gpu: Add ACPI property to align with device-tree") as well. For full disclosure, I use these kernel command line arguments: fbcon=font:10x18 drm_kms_helper.drm_fbdev_overalloc=112 amdgpu.noretry=1 amdgpu.mcbp=1 -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and Xwayland developer
