[PATCH 4/5] drm/amd: Convert USB-C PD F/W attributes into groups

[Mario Limonciello]

Rather than special casing the creation of the file, special case
the visibility to the supported dGPUs.

Signed-off-by: Mario Limonciello <mario.limoncie...@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 40 ++++++-------------------
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h |  1 -
 2 files changed, 9 insertions(+), 32 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index 93d014e69ee39..7872004ed7f9b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -45,9 +45,6 @@
 
 #define AMD_VBIOS_FILE_MAX_SIZE_B      (1024*1024*3)
 
-static int psp_sysfs_init(struct amdgpu_device *adev);
-static void psp_sysfs_fini(struct amdgpu_device *adev);
-
 static int psp_load_smu_fw(struct psp_context *psp);
 static int psp_rap_terminate(struct psp_context *psp);
 static int psp_securedisplay_terminate(struct psp_context *psp);
@@ -456,14 +453,6 @@ static int psp_sw_init(void *handle)
                }
        }
 
-       if (adev->ip_versions[MP0_HWIP][0] == IP_VERSION(11, 0, 0) ||
-           adev->ip_versions[MP0_HWIP][0] == IP_VERSION(11, 0, 7)) {
-               ret= psp_sysfs_init(adev);
-               if (ret) {
-                       return ret;
-               }
-       }
-
        ret = amdgpu_bo_create_kernel(adev, PSP_1_MEG, PSP_1_MEG,
                                      amdgpu_sriov_vf(adev) ?
                                      AMDGPU_GEM_DOMAIN_VRAM : 
AMDGPU_GEM_DOMAIN_GTT,
@@ -513,10 +502,6 @@ static int psp_sw_fini(void *handle)
        amdgpu_ucode_release(&psp->cap_fw);
        amdgpu_ucode_release(&psp->toc_fw);
 
-       if (adev->ip_versions[MP0_HWIP][0] == IP_VERSION(11, 0, 0) ||
-           adev->ip_versions[MP0_HWIP][0] == IP_VERSION(11, 0, 7))
-               psp_sysfs_fini(adev);
-
        kfree(cmd);
        cmd = NULL;
 
@@ -3612,6 +3597,7 @@ static DEVICE_ATTR(psp_vbflash_status, 0440, 
amdgpu_psp_vbflash_status, NULL);
 static struct attribute *flash_attrs[] = {
        &dev_attr_psp_vbflash_status.attr,
        &psp_vbflash_bin_attr.attr,
+       &dev_attr_usbc_pd_fw.attr,
        NULL
 };
 
@@ -3625,9 +3611,16 @@ static umode_t amdgpu_flash_attr_is_visible(struct 
kobject *kobj, struct attribu
                return 0;
 
        switch (adev->ip_versions[MP0_HWIP][0]) {
+       case IP_VERSION(11, 0, 0):
+       case IP_VERSION(11, 0, 7):
+               if (attr == &dev_attr_usbc_pd_fw.attr)
+                       return 0660;
+               return 0;
        case IP_VERSION(13, 0, 0):
        case IP_VERSION(13, 0, 7):
-               if (attr == &psp_vbflash_bin_attr.attr)
+               if (attr == &dev_attr_usbc_pd_fw.attr)
+                       return 0;
+               else if (attr == &psp_vbflash_bin_attr.attr)
                        return 0660;
                return 0440;
        default:
@@ -3658,21 +3651,6 @@ const struct amd_ip_funcs psp_ip_funcs = {
        .set_powergating_state = psp_set_powergating_state,
 };
 
-static int psp_sysfs_init(struct amdgpu_device *adev)
-{
-       int ret = device_create_file(adev->dev, &dev_attr_usbc_pd_fw);
-
-       if (ret)
-               DRM_ERROR("Failed to create USBC PD FW control file!");
-
-       return ret;
-}
-
-static void psp_sysfs_fini(struct amdgpu_device *adev)
-{
-       device_remove_file(adev->dev, &dev_attr_usbc_pd_fw);
-}
-
 const struct amdgpu_ip_block_version psp_v3_1_ip_block =
 {
        .type = AMD_IP_BLOCK_TYPE_PSP,
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h
index b441c07e5a16f..619b27e891b5b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h
@@ -521,5 +521,4 @@ void psp_copy_fw(struct psp_context *psp, uint8_t 
*start_addr, uint32_t bin_size
 
 int is_psp_fw_valid(struct psp_bin_desc bin);
 
-int amdgpu_psp_sysfs_init(struct amdgpu_device *adev);
 #endif
-- 
2.34.1