s/pcie/PCIe/ in the subject.
On Tue, May 23, 2023 at 12:02:32PM +0800, Shiwu Zhang wrote:
> v2: add the base class id for accelerator (lijo)
Please include a commit log. For PCI, the "v2: ..." stuff would go
below the "---" so it doesn't get included in the git commit. I don't
know what the DRM convention is.
It's OK if the commit log repeats the subject. The subject is like
the title of a story -- it's not the first sentence of the story.
Please include a spec citation for the PCI_BASE_CLASS_ACCELERATOR
values in the commit log. I think it's something like "PCI Code and
ID Assignment, r1.9, sec 1, 1.19".
> Signed-off-by: Shiwu Zhang <shiwu.zh...@amd.com>
> Acked-by: Lijo Lazar <lijo.la...@amd.com>
With the above:
Acked-by: Bjorn Helgaas <bhelg...@google.com> # pci_ids.h
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 5 +++++
> include/linux/pci_ids.h | 3 +++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 3d91e123f9bd..5d652e6f0b1e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -2042,6 +2042,11 @@ static const struct pci_device_id pciidlist[] = {
> .class_mask = 0xffffff,
> .driver_data = CHIP_IP_DISCOVERY },
>
> + { PCI_DEVICE(0x1002, PCI_ANY_ID),
> + .class = PCI_CLASS_ACCELERATOR_PROCESSING << 8,
> + .class_mask = 0xffffff,
> + .driver_data = CHIP_IP_DISCOVERY },
> +
> {0, 0, 0}
> };
>
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index b362d90eb9b0..4918ff26a987 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -151,6 +151,9 @@
> #define PCI_CLASS_SP_DPIO 0x1100
> #define PCI_CLASS_SP_OTHER 0x1180
>
> +#define PCI_BASE_CLASS_ACCELERATOR 0x12
> +#define PCI_CLASS_ACCELERATOR_PROCESSING 0x1200
> +
> #define PCI_CLASS_OTHERS 0xff
>
> /* Vendors and devices. Sort key: vendor first, device next. */
> --
> 2.17.1
>
