[AMD Official Use Only - General] (Adding Felix in CC)
I’m a fan of adding it to KFD as well. Felix, can you foresee any issues here? Kent From: amd-gfx <[email protected]> On Behalf Of Ho, Kenny Sent: Wednesday, May 24, 2023 3:23 PM To: Alex Deucher <[email protected]>; Mahfooz, Hamza <[email protected]> Cc: Li, Sun peng (Leo) <[email protected]>; Wentland, Harry <[email protected]>; Pan, Xinhui <[email protected]>; Siqueira, Rodrigo <[email protected]>; [email protected]; [email protected]; [email protected]; Daniel Vetter <[email protected]>; Deucher, Alexander <[email protected]>; David Airlie <[email protected]>; Koenig, Christian <[email protected]> Subject: Re: [PATCH v2] drm/amd/display: enable more strict compile checks [AMD Official Use Only - General] [AMD Official Use Only - General] (+ Felix) Should we do the same for other modules under amd (amdkfd)? I was going to enable full kernel werror in the kconfig used by my CI but this is probably better. Kenny ________________________________ From: Alex Deucher <[email protected]<mailto:[email protected]>> Sent: Wednesday, May 24, 2023 3:22 PM To: Mahfooz, Hamza <[email protected]<mailto:[email protected]>> Cc: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>>; Li, Sun peng (Leo) <[email protected]<mailto:[email protected]>>; Ho, Kenny <[email protected]<mailto:[email protected]>>; Pan, Xinhui <[email protected]<mailto:[email protected]>>; Siqueira, Rodrigo <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>>; Daniel Vetter <[email protected]<mailto:[email protected]>>; Deucher, Alexander <[email protected]<mailto:[email protected]>>; David Airlie <[email protected]<mailto:[email protected]>>; Wentland, Harry <[email protected]<mailto:[email protected]>>; Koenig, Christian <[email protected]<mailto:[email protected]>> Subject: Re: [PATCH v2] drm/amd/display: enable more strict compile checks On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz <[email protected]<mailto:[email protected]>> wrote: > > Currently, there are quite a number of issues that are quite easy for > the CI to catch, that slip through the cracks. Among them, there are > unused variable and indentation issues. Also, we should consider all > warnings to be compile errors, since the community will eventually end > up complaining about them. So, enable -Werror, -Wunused and > -Wmisleading-indentation for all kernel builds. > > Cc: Alex Deucher <[email protected]<mailto:[email protected]>> > Cc: Harry Wentland <[email protected]<mailto:[email protected]>> > Cc: Kenny Ho <[email protected]<mailto:[email protected]>> > Signed-off-by: Hamza Mahfooz > <[email protected]<mailto:[email protected]>> > --- > v2: fix grammatical error > --- > drivers/gpu/drm/amd/display/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/display/Makefile > b/drivers/gpu/drm/amd/display/Makefile > index 0d610cb376bb..3c44162ebe21 100644 > --- a/drivers/gpu/drm/amd/display/Makefile > +++ b/drivers/gpu/drm/amd/display/Makefile > @@ -26,6 +26,8 @@ > > AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH) > > +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation > + Care to enable this for the rest of amdgpu as well? Or send out an additional patch to do that? Either way: Reviewed-by: Alex Deucher <[email protected]<mailto:[email protected]>> Alex > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/ > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr > -- > 2.40.1 >
