[AMD Official Use Only - General]
Thanks for the fix. Please use move the +#ifdef CONFIG_ACPI_NUMA up a bit to
cover amdgpu_acpi_get_numa_size as well.
Thanks,
Lijo
-----Original Message-----
From: SHANMUGAM, SRINIVASAN <srinivasan.shanmu...@amd.com>
Sent: Friday, May 19, 2023 5:51 PM
To: Koenig, Christian <christian.koe...@amd.com>; Deucher, Alexander
<alexander.deuc...@amd.com>; Tuikov, Luben <luben.tui...@amd.com>; Lazar, Lijo
<lijo.la...@amd.com>
Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN
<srinivasan.shanmu...@amd.com>
Subject: [PATCH] drm/amdgpu: Fix unused amdgpu_acpi_get_numa_info function in
amdgpu_acpi_get_node_id()
Fix the below compiler complaining error:
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:860:33: error: unused function
'amdgpu_acpi_get_numa_info' [-Werror,-Wunused-function] static struct
amdgpu_numa_info *amdgpu_acpi_get_numa_info(uint32_t pxm)
^
1 error generated.
By guarding amdgpu_acpi_get_numa_info function, only when CONFIG_ACPI_NUMA is
enabled.
Cc: Christian König <christian.koe...@amd.com>
Cc: Lijo Lazar <lijo.la...@amd.com>
Cc: Luben Tuikov <luben.tui...@amd.com>
Cc: Alex Deucher <alexander.deuc...@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmu...@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
index 7150c09933cf..9433596076d0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
@@ -857,6 +857,7 @@ static inline uint64_t amdgpu_acpi_get_numa_size(int nid)
return managed_pages * PAGE_SIZE;
}
+#ifdef CONFIG_ACPI_NUMA
static struct amdgpu_numa_info *amdgpu_acpi_get_numa_info(uint32_t pxm) {
struct amdgpu_numa_info *numa_info;
@@ -886,6 +887,7 @@ static struct amdgpu_numa_info
*amdgpu_acpi_get_numa_info(uint32_t pxm)
return numa_info;
}
+#endif
/**
* amdgpu_acpi_get_node_id - obtain the NUMA node id for corresponding amdgpu
--
2.25.1
