> -----Original Message-----
> From: Dmitry Baryshkov <dmitry.barysh...@linaro.org>
> Sent: Thursday, March 9, 2023 4:49 PM
> To: Chen, Guchun <guchun.c...@amd.com>; amd-
> g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Deucher,
> Alexander <alexander.deuc...@amd.com>; Zhang, Hawking
> <hawking.zh...@amd.com>; spassw...@web.de; m...@fireburn.co.uk
> Subject: Re: [PATCH 2/2] drm/probe_helper: warning on poll_enabled for
> issue catching
>
> On 09/03/2023 07:48, Guchun Chen wrote:
> > In order to catch issues in other drivers to ensure proper call
> > sequence of polling function.
> >
> > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411
> > Fixes: a4e771729a51("drm/probe_helper: sort out poll_running vs
> > poll_enabled")
>
> Previously it was suggested that this is not a fix, so the Fixes header is
> incorrect.
>
> Also please use -vN when preparing/sending patchsets. This is v2.
Will fix these in V3.
Regards,
Guchun
> > Reported-by: Bert Karwatzki <spassw...@web.de>
> > Suggested-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org>
> > Signed-off-by: Guchun Chen <guchun.c...@amd.com>
> > ---
> > drivers/gpu/drm/drm_probe_helper.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_probe_helper.c
> > b/drivers/gpu/drm/drm_probe_helper.c
> > index 8127be134c39..85e0e80d4a52 100644
> > --- a/drivers/gpu/drm/drm_probe_helper.c
> > +++ b/drivers/gpu/drm/drm_probe_helper.c
> > @@ -852,6 +852,8 @@
> EXPORT_SYMBOL(drm_kms_helper_is_poll_worker);
> > */
> > void drm_kms_helper_poll_disable(struct drm_device *dev)
> > {
> > + WARN_ON(!dev->mode_config.poll_enabled);
> > +
> > if (dev->mode_config.poll_running)
> > drm_kms_helper_disable_hpd(dev);
> >
>
> --
> With best wishes
> Dmitry
