Hi Jonathan, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on linus/master v6.2-rc5] [cannot apply to drm-misc/drm-misc-next drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jonathan-Kim/drm-amdkfd-add-debug-and-runtime-enable-interface/20230128-092952 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link: https://lore.kernel.org/r/20230125195401.4183544-9-jonathan.kim%40amd.com patch subject: [PATCH 08/32] drm/amdgpu: add gfx10 hw debug mode enable and disable calls config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230129/202301291502.el73nchv-...@intel.com/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/ca722ec7f4d749b61a30b4654fabf05f03d8d2cf git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jonathan-Kim/drm-amdkfd-add-debug-and-runtime-enable-interface/20230128-092952 git checkout ca722ec7f4d749b61a30b4654fabf05f03d8d2cf # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/amd/amdgpu/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <l...@intel.com> All warnings (new ones prefixed by >>): >> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c:750:10: warning: no >> previous prototype for 'kgd_gfx_v10_enable_debug_trap' [-Wmissing-prototypes] 750 | uint32_t kgd_gfx_v10_enable_debug_trap(struct amdgpu_device *adev, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c:787:10: warning: no >> previous prototype for 'kgd_gfx_v10_disable_debug_trap' >> [-Wmissing-prototypes] 787 | uint32_t kgd_gfx_v10_disable_debug_trap(struct amdgpu_device *adev, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc_types.h:36, from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:30, from drivers/gpu/drm/amd/amdgpu/../include/dm_pp_interface.h:26, from drivers/gpu/drm/amd/amdgpu/amdgpu.h:64, from drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c:22: drivers/gpu/drm/amd/amdgpu/../display/dc/dc_hdmi_types.h:53:22: warning: 'dp_hdmi_dongle_signature_str' defined but not used [-Wunused-const-variable=] 53 | static const uint8_t dp_hdmi_dongle_signature_str[] = "DP-HDMI ADAPTOR"; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/kgd_gfx_v10_enable_debug_trap +750 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c 749 > 750 uint32_t kgd_gfx_v10_enable_debug_trap(struct amdgpu_device *adev, 751 bool restore_dbg_registers, 752 uint32_t vmid) 753 { 754 755 mutex_lock(&adev->grbm_idx_mutex); 756 757 kgd_gfx_v10_set_wave_launch_stall(adev, vmid, true); 758 759 /* assume gfx off is disabled for the debug session if rlc restore not supported. */ 760 if (restore_dbg_registers) { 761 uint32_t data = 0; 762 763 data = REG_SET_FIELD(data, SPI_GDBG_TRAP_CONFIG, 764 VMID_SEL, 1 << vmid); 765 data = REG_SET_FIELD(data, SPI_GDBG_TRAP_CONFIG, 766 TRAP_EN, 1); 767 WREG32(SOC15_REG_OFFSET(GC, 0, mmSPI_GDBG_TRAP_CONFIG), data); 768 WREG32(SOC15_REG_OFFSET(GC, 0, mmSPI_GDBG_TRAP_DATA0), 0); 769 WREG32(SOC15_REG_OFFSET(GC, 0, mmSPI_GDBG_TRAP_DATA1), 0); 770 771 kgd_gfx_v10_set_wave_launch_stall(adev, vmid, false); 772 773 mutex_unlock(&adev->grbm_idx_mutex); 774 775 return 0; 776 } 777 778 WREG32(SOC15_REG_OFFSET(GC, 0, mmSPI_GDBG_TRAP_MASK), 0); 779 780 kgd_gfx_v10_set_wave_launch_stall(adev, vmid, false); 781 782 mutex_unlock(&adev->grbm_idx_mutex); 783 784 return 0; 785 } 786 > 787 uint32_t kgd_gfx_v10_disable_debug_trap(struct amdgpu_device *adev, 788 bool keep_trap_enabled, 789 uint32_t vmid) 790 { 791 mutex_lock(&adev->grbm_idx_mutex); 792 793 kgd_gfx_v10_set_wave_launch_stall(adev, vmid, true); 794 795 WREG32(SOC15_REG_OFFSET(GC, 0, mmSPI_GDBG_TRAP_MASK), 0); 796 797 kgd_gfx_v10_set_wave_launch_stall(adev, vmid, false); 798 799 mutex_unlock(&adev->grbm_idx_mutex); 800 801 return 0; 802 } 803 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
