Always check if fru_addr is not NULL. This commit also fixes a "smatch"
warning.

Cc: Alex Deucher <alexander.deuc...@amd.com>
Cc: Dan Carpenter <erro...@gmail.com>
Cc: kernel test robot <l...@intel.com>
Cc: AMD Graphics <amd-gfx@lists.freedesktop.org>
Signed-off-by: Luben Tuikov <luben.tui...@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
index 2c38ac7bc643d5..4620c4712ce32a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
@@ -64,7 +64,8 @@ static bool is_fru_eeprom_supported(struct amdgpu_device 
*adev, u32 *fru_addr)
                            sizeof(atom_ctx->vbios_version)) ||
                    strnstr(atom_ctx->vbios_version, "D163",
                            sizeof(atom_ctx->vbios_version))) {
-                       *fru_addr = FRU_EEPROM_MADDR_6;
+                       if (fru_addr)
+                               *fru_addr = FRU_EEPROM_MADDR_6;
                        return true;
                } else {
                        return false;
@@ -83,7 +84,8 @@ static bool is_fru_eeprom_supported(struct amdgpu_device 
*adev, u32 *fru_addr)
                                    sizeof(atom_ctx->vbios_version))) {
                                return false;
                        } else {
-                               *fru_addr = FRU_EEPROM_MADDR_6;
+                               if (fru_addr)
+                                       *fru_addr = FRU_EEPROM_MADDR_6;
                                return true;
                        }
                } else {

base-commit: 20e03e7f6e8efd42168db6d3fe044b804e0ede8f
-- 
2.39.0.rc2

Reply via email to