[Public] Reviewed-by: Harish Kasiviswanathan <harish.kasiviswanat...@amd.com>
From: Deucher, Alexander <alexander.deuc...@amd.com> Sent: Thursday, October 27, 2022 9:56 AM To: Sider, Graham <graham.si...@amd.com>; amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish <harish.kasiviswanat...@amd.com> Subject: Re: [PATCH] drm/amdgpu: disable GFXOFF during compute for GFX11 [Public] Acked-by: Alex Deucher <alexander.deuc...@amd.com<mailto:alexander.deuc...@amd.com>> ________________________________ From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org<mailto:amd-gfx-boun...@lists.freedesktop.org>> on behalf of Graham Sider <graham.si...@amd.com<mailto:graham.si...@amd.com>> Sent: Wednesday, October 26, 2022 4:10 PM To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> <amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>> Cc: Kasiviswanathan, Harish <harish.kasiviswanat...@amd.com<mailto:harish.kasiviswanat...@amd.com>>; Sider, Graham <graham.si...@amd.com<mailto:graham.si...@amd.com>> Subject: [PATCH] drm/amdgpu: disable GFXOFF during compute for GFX11 Temporary workaround to fix issues observed in some compute applications when GFXOFF is enabled on GFX11. Signed-off-by: Graham Sider <graham.si...@amd.com<mailto:graham.si...@amd.com>> --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c index 37db39ba8718..0d764c15f6bf 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c @@ -706,6 +706,13 @@ int amdgpu_amdkfd_submit_ib(struct amdgpu_device *adev, void amdgpu_amdkfd_set_compute_idle(struct amdgpu_device *adev, bool idle) { + /* Temporary workaround to fix issues observed in some + * compute applications when GFXOFF is enabled on GFX11. + */ + if (IP_VERSION_MAJ(adev->ip_versions[GC_HWIP][0]) == 11) { + pr_debug("GFXOFF is %s\n", idle ? "enabled" : "disabled"); + amdgpu_gfx_off_ctrl(adev, idle); + } amdgpu_dpm_switch_power_profile(adev, PP_SMC_POWER_PROFILE_COMPUTE, !idle); -- 2.25.1
