[Public] Acked-by: Alex Deucher <alexander.deuc...@amd.com> ________________________________ From: Mahfooz, Hamza <hamza.mahf...@amd.com> Sent: Thursday, September 1, 2022 10:15 AM To: linux-ker...@vger.kernel.org <linux-ker...@vger.kernel.org> Cc: Mahfooz, Hamza <hamza.mahf...@amd.com>; Wentland, Harry <harry.wentl...@amd.com>; Li, Sun peng (Leo) <sunpeng...@amd.com>; Siqueira, Rodrigo <rodrigo.sique...@amd.com>; Deucher, Alexander <alexander.deuc...@amd.com>; Koenig, Christian <christian.koe...@amd.com>; Pan, Xinhui <xinhui....@amd.com>; David Airlie <airl...@linux.ie>; Daniel Vetter <dan...@ffwll.ch>; Kazlauskas, Nicholas <nicholas.kazlaus...@amd.com>; Lei, Jun <jun....@amd.com>; Somasundaram, Meenakshikumar <meenakshikumar.somasunda...@amd.com>; Lee, Alvin <alvin.l...@amd.com>; Leung, Martin <martin.le...@amd.com>; Tam, Samson <samson....@amd.com>; Hung, Alex <alex.h...@amd.com>; Liu, Wenjing <wenjing....@amd.com>; Aberback, Joshua <joshua.aberb...@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; dri-de...@lists.freedesktop.org <dri-de...@lists.freedesktop.org> Subject: [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()
Address the following warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 3508 | if (update_type != UPDATE_TYPE_FAST) | ^~ drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ 3510 | if (update_type != UPDATE_TYPE_FAST) | ^~ Signed-off-by: Hamza Mahfooz <hamza.mahf...@amd.com> --- v2: implement feedback from Alvin --- drivers/gpu/drm/amd/display/dc/core/dc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index b49237390cce..9860bf38c547 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c @@ -3507,9 +3507,10 @@ static void commit_planes_for_stream(struct dc *dc, if (update_type != UPDATE_TYPE_FAST) dc->hwss.post_unlock_program_front_end(dc, context); - if (update_type != UPDATE_TYPE_FAST) - if (dc->hwss.commit_subvp_config) - dc->hwss.commit_subvp_config(dc, context); + + if (update_type != UPDATE_TYPE_FAST) + if (dc->hwss.commit_subvp_config) + dc->hwss.commit_subvp_config(dc, context); /* Since phantom pipe programming is moved to post_unlock_program_front_end, * move the SubVP lock to after the phantom pipes have been setup -- 2.37.2