[AMD Official Use Only - General]

Thanks comment, I will change it.
-----Original Message-----
From: André Almeida <andrealm...@igalia.com> 
Sent: Thursday, July 21, 2022 9:11 PM
To: Guo, Shikai <shikai....@amd.com>
Cc: Deucher, Alexander <alexander.deuc...@amd.com>; 
amd-gfx@lists.freedesktop.org; Liang, Prike <prike.li...@amd.com>; Quan, Evan 
<evan.q...@amd.com>
Subject: Re: [PATCH] drm/amd/pm: Add get_gfx_off_status interface

Hi Shikai,

Could you change the commit message to

 drm/amd/pm: Add get_gfx_off_status interface for yellow carp

Otherwise, we are going to have duplicated commit messages for each new 
architecture supporting get_gfx_off_status.

Also, giving that this is the second version of your patch, the subject should 
be [PATCH v2], and the patch should contain a changelog compared to the 
previous patch version.

Às 05:57 de 21/07/22, shikai....@amd.com escreveu:
> From: Shikai Guo <shikai....@amd.com>
> 
> add get_gfx_off_status interface to yellow_carp_ppt_funcs structure.
> 
> Signed-off-by: Shikai Guo <shikai....@amd.com>


Thanks,
        André

Reply via email to