[AMD Official Use Only] OK. If that can help the debugging for RAS development, I’m fine with it. Reviewed-by: Evan Quan <evan.q...@amd.com>
BR Evan From: Yang, Stanley <stanley.y...@amd.com> Sent: Monday, December 6, 2021 8:37 PM To: Quan, Evan <evan.q...@amd.com>; amd-gfx@lists.freedesktop.org; Zhang, Hawking <hawking.zh...@amd.com>; Clements, John <john.cleme...@amd.com>; Zhou1, Tao <tao.zh...@amd.com>; Li, Candice <candice...@amd.com>; Chai, Thomas <yipeng.c...@amd.com> Subject: 答复: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed Hi Evan, The error prompts in function smu_cmn_send_smc_msg_with_param do not cover all failed cases since it only prints reg stat SMU_RESP_NONE, SMU_RESP_BUSY_OTHER or response -EREMOTEIO. I think it is better update reg error stat judgment conditions to print more error msg. Regards, Stanley 发件人: Quan, Evan <evan.q...@amd.com<mailto:evan.q...@amd.com>> 日期: 星期一, 2021年12月6日 上午9:43 收件人: Yang, Stanley <stanley.y...@amd.com<mailto:stanley.y...@amd.com>>, amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> <amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>>, Zhang, Hawking <hawking.zh...@amd.com<mailto:hawking.zh...@amd.com>>, Clements, John <john.cleme...@amd.com<mailto:john.cleme...@amd.com>>, Zhou1, Tao <tao.zh...@amd.com<mailto:tao.zh...@amd.com>>, Li, Candice <candice...@amd.com<mailto:candice...@amd.com>>, Chai, Thomas <yipeng.c...@amd.com<mailto:yipeng.c...@amd.com>> 抄送: Yang, Stanley <stanley.y...@amd.com<mailto:stanley.y...@amd.com>> 主题: RE: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed [AMD Official Use Only] Hi Stanley, There is already error prompts in the smu_cmn_send_smc_msg_with_param() used by the API mentioned below. Can that cover your use case? BR Evan > -----Original Message----- > From: Stanley.Yang <stanley.y...@amd.com<mailto:stanley.y...@amd.com>> > Sent: Sunday, December 5, 2021 6:02 PM > To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>; > Zhang, Hawking > <hawking.zh...@amd.com<mailto:hawking.zh...@amd.com>>; Clements, John > <john.cleme...@amd.com<mailto:john.cleme...@amd.com>>; > Zhou1, Tao <tao.zh...@amd.com<mailto:tao.zh...@amd.com>>; Li, Candice > <candice...@amd.com<mailto:candice...@amd.com>>; > Chai, Thomas <yipeng.c...@amd.com<mailto:yipeng.c...@amd.com>>; Quan, Evan > <evan.q...@amd.com<mailto:evan.q...@amd.com>> > Cc: Yang, Stanley <stanley.y...@amd.com<mailto:stanley.y...@amd.com>> > Subject: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed > > Signed-off-by: Stanley.Yang > <stanley.y...@amd.com<mailto:stanley.y...@amd.com>> > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c > b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c > index 6e781cee8bb6..e0a8224e466f 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c > @@ -1815,7 +1815,7 @@ static ssize_t aldebaran_get_ecc_info(struct > smu_context *smu, > smu_table->ecc_table, > false); > if (ret) { > - dev_info(smu->adev->dev, "Failed to export SMU ecc > table!\n"); > + dev_info(smu->adev->dev, "Failed to export SMU ecc table! > ret %d.\n", ret); > return ret; > } > > -- > 2.17.1
