Do we need to consider backward compatibility?
Best wishes
Emily Deng
>-----Original Message-----
>From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Liu,
>Shaoyun
>Sent: Thursday, June 3, 2021 11:10 PM
>To: Luo, Zhigang <zhigang....@amd.com>; amd-gfx@lists.freedesktop.org
>Cc: Luo, Zhigang <zhigang....@amd.com>
>Subject: RE: [PATCH 1/5] drm/amdgpu: remove sriov vf checking from getting fb
>location
>
>[AMD Official Use Only]
>
>Looks ok to me .
>
>Reviewed-By : Shaoyun.liu <shaoy...@amd.com>
>
>-----Original Message-----
>From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Zhigang
>Luo
>Sent: Thursday, June 3, 2021 10:13 AM
>To: amd-gfx@lists.freedesktop.org
>Cc: Luo, Zhigang <zhigang....@amd.com>
>Subject: [PATCH 1/5] drm/amdgpu: remove sriov vf checking from getting fb
>location
>
>host driver programmed fb location registers for vf, no need to check anymore.
>
>Signed-off-by: Zhigang Luo <zhigang....@amd.com>
>---
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>index ceb3968d8326..1c2d9fde9021 100644
>--- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>@@ -1292,10 +1292,7 @@ static int gmc_v9_0_late_init(void *handle) static
>void gmc_v9_0_vram_gtt_location(struct amdgpu_device *adev,
> struct amdgpu_gmc *mc)
> {
>- u64 base = 0;
>-
>- if (!amdgpu_sriov_vf(adev))
>- base = adev->mmhub.funcs->get_fb_location(adev);
>+ u64 base = adev->mmhub.funcs->get_fb_location(adev);
>
> /* add the xgmi offset of the physical node */
> base += adev->gmc.xgmi.physical_node_id * adev-
>>gmc.xgmi.node_segment_size;
>--
>2.17.1
>
>_______________________________________________
>amd-gfx mailing list
>amd-gfx@lists.freedesktop.org
>https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.fre
>edesktop.org%2Fmailman%2Flistinfo%2Famd-
>gfx&data=04%7C01%7CEmily.Deng%40amd.com%7Cd41e78b1a3af4f08ff
>d108d926a1a2d8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63
>7583297946242271%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi
>LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Nsz
>ZyRZHCxj%2FIJ1hYoSrkv3LpTmF9FbchpNMtQ2GE5M%3D&reserved=0
>_______________________________________________
>amd-gfx mailing list
>amd-gfx@lists.freedesktop.org
>https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.fre
>edesktop.org%2Fmailman%2Flistinfo%2Famd-
>gfx&data=04%7C01%7CEmily.Deng%40amd.com%7Cd41e78b1a3af4f08ff
>d108d926a1a2d8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63
>7583297946242271%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi
>LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Nsz
>ZyRZHCxj%2FIJ1hYoSrkv3LpTmF9FbchpNMtQ2GE5M%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
