RE: [PATCH 1/1] drm/amdkfd: Use a new capability bit for SRAM ECC

[Russell, Kent]

[AMD Public Use]

Reviewed-by: Kent Russell <kent.russ...@amd.com>

> -----Original Message-----
> From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Felix 
> Kuehling
> Sent: Friday, February 26, 2021 5:46 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH 1/1] drm/amdkfd: Use a new capability bit for SRAM ECC
> 
> Existing, buggy user mode breaks when SRAM ECC is correctly reported as
> "enabled". To avoid breaking existing user mode, deprecate that bit and
> leave it as 0. Define a new bit to report the actual SRAM ECC mode that
> new, correct user mode can use in the future.
> 
> Fixes: 7ec177bdcfc1 ("drm/amdkfd: fix set kfd node ras properties value")
> Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
> b/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
> index 416fd910e12e..b8b68087bd7a 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
> @@ -47,13 +47,14 @@
>  #define HSA_CAP_DOORBELL_TYPE_2_0            0x2
>  #define HSA_CAP_AQL_QUEUE_DOUBLE_MAP         0x00004000
> 
> -#define HSA_CAP_SRAM_EDCSUPPORTED            0x00080000
> +#define HSA_CAP_RESERVED_WAS_SRAM_EDCSUPPORTED       0x00080000 /* Old buggy
> user mode depends on this being 0 */
>  #define HSA_CAP_MEM_EDCSUPPORTED             0x00100000
>  #define HSA_CAP_RASEVENTNOTIFY                       0x00200000
>  #define HSA_CAP_ASIC_REVISION_MASK           0x03c00000
>  #define HSA_CAP_ASIC_REVISION_SHIFT          22
> +#define HSA_CAP_SRAM_EDCSUPPORTED            0x04000000
> 
> -#define HSA_CAP_RESERVED                     0xfc078000
> +#define HSA_CAP_RESERVED                     0xf80f8000
> 
>  struct kfd_node_properties {
>       uint64_t hive_id;
> --
> 2.30.0
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.or
> g%2Fmailman%2Flistinfo%2Famd-
> gfx&amp;data=04%7C01%7Ckent.russell%40amd.com%7Cb8d46efc3f554cef4f7308d8daa85
> 3bb%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637499763789222071%7CUnk
> nown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV
> CI6Mn0%3D%7C1000&amp;sdata=ZhBBLDSK21I9o%2F1wsoFpWUlPtiezJ2rHHmIvJ51lsT4%3
> D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx