[AMD Public Use] No problem. Another patch works for me. Thank you
Regards, Hawking From: Wang, Kevin(Yang) <kevin1.w...@amd.com> Sent: Monday, March 1, 2021 13:27 To: Zhang, Hawking <hawking.zh...@amd.com>; amd-gfx@lists.freedesktop.org Cc: Li, Candice <candice...@amd.com> Subject: Re: [PATCH] drm/amdgpu: correct TA RAP firmware information print error [AMD Public Use] yes, I have the same idea and agree with you. but patch is merged, I will add a new patch to refine it. Best Regards, Kevin ________________________________ From: Zhang, Hawking <hawking.zh...@amd.com<mailto:hawking.zh...@amd.com>> Sent: Monday, March 1, 2021 1:23 PM To: Wang, Kevin(Yang) <kevin1.w...@amd.com<mailto:kevin1.w...@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> <amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>> Cc: Li, Candice <candice...@amd.com<mailto:candice...@amd.com>>; Wang, Kevin(Yang) <kevin1.w...@amd.com<mailto:kevin1.w...@amd.com>> Subject: RE: [PATCH] drm/amdgpu: correct TA RAP firmware information print error [AMD Public Use] Instead of hard code the number of TA, it would be better to leverage enum ta_fw_type definition, explicitly call out TA_TYPE for each case in both amdgpu_firmware_info and amdgpu_debugfs_firmware_info_show. Regards, Hawking -----Original Message----- From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org<mailto:amd-gfx-boun...@lists.freedesktop.org>> On Behalf Of Kevin Wang Sent: Monday, March 1, 2021 10:52 To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Cc: Li, Candice <candice...@amd.com<mailto:candice...@amd.com>>; Wang, Kevin(Yang) <kevin1.w...@amd.com<mailto:kevin1.w...@amd.com>> Subject: [PATCH] drm/amdgpu: correct TA RAP firmware information print error miss RAP TA in loop ( when i == 4) Fix: drm/amdgpu: add RAP TA version print in amdgpu_firmware_info Signed-off-by: Kevin Wang <kevin1.w...@amd.com<mailto:kevin1.w...@amd.com>> Reported-by: Candice Li <candice...@amd.com<mailto:candice...@amd.com>> --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c index a5ed9530f542..6c8ea9d26320 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c @@ -1472,7 +1472,7 @@ static int amdgpu_debugfs_firmware_info_show(struct seq_file *m, void *unused) fw_info.feature, fw_info.ver); query_fw.fw_type = AMDGPU_INFO_FW_TA; - for (i = 0; i < 4; i++) { + for (i = 0; i < 5; i++) { query_fw.index = i; ret = amdgpu_firmware_info(&fw_info, &query_fw, adev); if (ret) -- 2.17.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Chawking.zhang%40amd.com%7C76e6934844e14fd942ec08d8dc5d042d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637501639364874702%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ouIjHlz93nX%2Fj3gZ9tdhHxYX501bJmQm3UzqpDwSJGw%3D&reserved=0
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx