Hi! I am not quite familiar with it, and I was wondering why this flag is blocked. As the VM subsystem supports giant pages, it might be useful to add this flag in amdgpu_gem_create_ioctl.
> -----原始邮件----- > 发件人: "Christian König" <ckoenig.leichtzumer...@gmail.com> > 发送时间: 2020-12-08 15:41:02 (星期二) > 收件人: "Chen Lei" <chenlei...@ict.ac.cn>, alexander.deuc...@amd.com, christian.koe...@amd.com > 抄送: amd-gfx@lists.freedesktop.org > 主题: Re: [PATCH] drm/amdgpu: add the missing AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS flag > > Am 08.12.20 um 03:50 schrieb Chen Lei: > > Add the AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS flag in amdgpu_gem_create_ioctl. > > > > Signed-off-by: Chen Lei <chenlei...@ict.ac.cn> > > NAK, that is not missing but intentionally blocked. > > Christian. > > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c > > index 7e8265da9..da18aeff7 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c > > @@ -233,6 +233,7 @@ int amdgpu_gem_create_ioctl(struct drm_device *dev, void *data, > > AMDGPU_GEM_CREATE_NO_CPU_ACCESS | > > AMDGPU_GEM_CREATE_CPU_GTT_USWC | > > AMDGPU_GEM_CREATE_VRAM_CLEARED | > > + AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS | > > AMDGPU_GEM_CREATE_VM_ALWAYS_VALID | > > AMDGPU_GEM_CREATE_EXPLICIT_SYNC | > > AMDGPU_GEM_CREATE_ENCRYPTED)) </chenlei...@ict.ac.cn></chenlei...@ict.ac.cn></ckoenig.leichtzumer...@gmail.com> _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
