Re: [PATCH] drm/amdgpu: fix the issue that apu has no smu firmware binary

[Wang, Kevin(Yang)]

[AMD Official Use Only - Internal Distribution Only]

Reviewed-by: Kevin Wang <kevin1.w...@amd.com>

Best Regards,
Kevin

________________________________
From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Huang Rui 
<ray.hu...@amd.com>
Sent: Tuesday, October 13, 2020 7:45 PM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Huang, Ray <ray.hu...@amd.com>
Subject: [PATCH] drm/amdgpu: fix the issue that apu has no smu firmware binary

The driver needn't load smu binary on APU platforms.

Signed-off-by: Huang Rui <ray.hu...@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c 
b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 9d31f9339e02..042ad5e4292b 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
@@ -7049,7 +7049,7 @@ static int gfx_v10_0_hw_init(void *handle)
                  * loaded firstly, so in direct type, it has to load smc ucode
                  * here before rlc.
                  */
-               if (adev->smu.ppt_funcs != NULL) {
+               if (adev->smu.ppt_funcs != NULL && !(adev->flags & AMD_IS_APU)) 
{
                         r = smu_load_microcode(&adev->smu);
                         if (r)
                                 return r;
--
2.25.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7CKevin1.Wang%40amd.com%7C2bcdef4a06454092df7708d86f6d7f8b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637381863385762892&amp;sdata=PK8E49RMQ3myvBXdV7pE7rxQTRd9p7SVGJOhcXUFNHE%3D&amp;reserved=0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx