From: Alvin Lee <alvin.l...@amd.com>

[Why]
DAL resume from BACO time is longer if we always flush inst_fb

[How]
Check if backdoor loading to flush inst_fb

Signed-off-by: Alvin Lee <alvin.l...@amd.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlaus...@amd.com>
Acked-by: Eryk Brol <eryk.b...@amd.com>
---
 drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c 
b/drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c
index 08da423b24a1..033ace4be445 100644
--- a/drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c
+++ b/drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c
@@ -404,15 +404,16 @@ enum dmub_status dmub_srv_hw_init(struct dmub_srv *dmub,
                cw1.region.base = DMUB_CW1_BASE;
                cw1.region.top = cw1.region.base + stack_fb->size - 1;
 
-               /**
-                * Read back all the instruction memory so we don't hang the
-                * DMCUB when backdoor loading if the write from x86 hasn't been
-                * flushed yet. This only occurs in backdoor loading.
-                */
-               dmub_flush_buffer_mem(inst_fb);
+               if (params->load_inst_const && dmub->hw_funcs.backdoor_load) {
+                   /**
+                    * Read back all the instruction memory so we don't hang the
+                    * DMCUB when backdoor loading if the write from x86 hasn't 
been
+                    * flushed yet. This only occurs in backdoor loading.
+                    */
+                   dmub_flush_buffer_mem(inst_fb);
+                   dmub->hw_funcs.backdoor_load(dmub, &cw0, &cw1);
+               }
 
-               if (params->load_inst_const && dmub->hw_funcs.backdoor_load)
-                       dmub->hw_funcs.backdoor_load(dmub, &cw0, &cw1);
        }
 
        if (dmub->hw_funcs.reset)
-- 
2.25.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to