Hi David, Explicit sync has nothing to do with this. This is for implicit sync, which is required by DRI3. This fix allows removing existing inefficiencies from drivers, so it's a good thing.
Marek On Wed., Jun. 10, 2020, 03:56 Chunming Zhou, <zhou...@amd.com> wrote: > > 在 2020/6/10 15:41, Christian König 写道: > > That's true, but for now we are stuck with the implicit sync for quite a > number of use cases. > > My problem is rather that we already tried this and it backfired > immediately. > > I do remember that it was your patch who introduced the pipeline sync flag > handling and I warned that this could be problematic. You then came back > with a QA result saying that this is indeed causing a huge performance drop > in one test case and we need to do something else. Together we then came up > with the different handling between implicit and explicit sync. > > Isn't pipeline sync flag to fix some issue because of parralel execution > between jobs in one pipeline? I really don't have this memory in mind why > that's realted to this, Or do you mean extra sync hides many other > potential issues? > > Anyway, when I go through Vulkan WSI code, the synchronization isn't so > smooth between OS window system. And when I saw Jason drives explicit sync > through the whole Linux ecosystem like Android window system does, I feel > that's really a good direction. > > -David > > > But I can't find that stupid mail thread any more. I knew that it was a > couple of years ago when we started with the explicit sync for Vulkan. > > Christian. > > Am 10.06.20 um 08:29 schrieb Zhou, David(ChunMing): > > [AMD Official Use Only - Internal Distribution Only] > > > > Not sue if this is right direction, I think usermode wants all > synchronizations to be explicit. Implicit sync often confuses people who > don’t know its history. I remember Jason from Intel is driving explicit > synchronization through the Linux ecosystem, which even removes implicit > sync of shared buffer. > > > > -David > > > > *From:* amd-gfx <amd-gfx-boun...@lists.freedesktop.org> > <amd-gfx-boun...@lists.freedesktop.org> *On Behalf Of *Marek Olšák > *Sent:* Tuesday, June 9, 2020 6:58 PM > *To:* amd-gfx mailing list <amd-gfx@lists.freedesktop.org> > <amd-gfx@lists.freedesktop.org> > *Subject:* [PATCH] drm/amdgpu: remove distinction between explicit and > implicit sync (v2) > > > > Hi, > > > > This enables a full pipeline sync for implicit sync. It's Christian's > patch with the driver version bumped. With this, user mode drivers don't > have to wait for idle at the end of gfx IBs. > > > > Any concerns? > > > > Thanks, > > Marek > > _______________________________________________ > amd-gfx mailing > listamd-gfx@lists.freedesktop.orghttps://lists.freedesktop.org/mailman/listinfo/amd-gfx > > <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CDavid1.Zhou%40amd.com%7C47e97eb8e3654708f7ff08d80d11bcf7%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637273717119277965&sdata=EFq2J33HIOiIS3bok2ZcIz%2FhE%2FVs9T0HPy0UFi92Nf4%3D&reserved=0> > > >
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
