[AMD Official Use Only - Internal Distribution Only]
thanks.
Reviewed-by: Kevin Wang <kevin1.w...@amd.com>
Best Regads,
Kevin
________________________________
From: Dan Carpenter <dan.carpen...@oracle.com>
Sent: Wednesday, May 20, 2020 9:08 PM
To: Deucher, Alexander <alexander.deuc...@amd.com>; Wang, Kevin(Yang)
<kevin1.w...@amd.com>
Cc: Koenig, Christian <christian.koe...@amd.com>; David Airlie
<airl...@linux.ie>; Daniel Vetter <dan...@ffwll.ch>; Quan, Evan
<evan.q...@amd.com>; Huang, Ray <ray.hu...@amd.com>; Feng, Kenneth
<kenneth.f...@amd.com>; Tao, Yintian <yintian....@amd.com>; Zhang, Hawking
<hawking.zh...@amd.com>; amd-gfx@lists.freedesktop.org
<amd-gfx@lists.freedesktop.org>; dri-de...@lists.freedesktop.org
<dri-de...@lists.freedesktop.org>; linux-ker...@vger.kernel.org
<linux-ker...@vger.kernel.org>; kernel-janit...@vger.kernel.org
<kernel-janit...@vger.kernel.org>
Subject: [PATCH v2] drm/amdgpu: off by on in amdgpu_device_attr_create_groups()
error handling
This loop in the error handling code should start a "i - 1" and end at
"i == 0". Currently it starts a "i" and ends at "i == 1". The result
is that it removes one attribute that wasn't created yet, and leaks the
zeroeth attribute.
Fixes: 4e01847c38f7 ("drm/amdgpu: optimize amdgpu device attribute code")
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
---
v2: style change
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
index b75362bf0742..e809534fabd4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
@@ -1942,9 +1942,8 @@ static int amdgpu_device_attr_create_groups(struct
amdgpu_device *adev,
return 0;
failed:
- for (; i > 0; i--) {
+ while (i--)
amdgpu_device_attr_remove(adev, &attrs[i]);
- }
return ret;
}
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
