Re: [PATCH 06/36] drm/amdgpu: use the unlocked drm_gem_object_put

[Christian König]

Am 07.05.20 um 20:03 schrieb Sam Ravnborg:
Hi Emil.
On Thu, May 07, 2020 at 04:07:52PM +0100, Emil Velikov wrote:
From: Emil Velikov <emil.veli...@collabora.com>

The driver does not hold struct_mutex, thus using the locked version of
the helper is incorrect.

Cc: Alex Deucher <alexander.deuc...@amd.com>
Cc: Christian König <christian.koe...@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Fixes: a39414716ca0 ("drm/amdgpu: add independent DMA-buf import v9"):
Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
index 43d8ed7dbd00..652c57a3b847 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
@@ -587,7 +587,7 @@ struct drm_gem_object *amdgpu_gem_prime_import(struct 
drm_device *dev,
        attach = dma_buf_dynamic_attach(dma_buf, dev->dev,
                                        &amdgpu_dma_buf_attach_ops, obj);
        if (IS_ERR(attach)) {
-               drm_gem_object_put(obj);
+               drm_gem_object_put_unlocked(obj);
                return ERR_CAST(attach);
        }
Likewise previous patch.
Drop this as the patch is correct after the rename a few pathces later.

Well this is a bug fix in the error path and should probably be back 
ported, so having a separate patch is certainly a good idea.

Christian.


        Sam

  
--
2.25.1

_______________________________________________
dri-devel mailing list
dri-de...@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=02%7C01%7Cchristian.koenig%40amd.com%7C41036bd7ab804d8bebdf08d7f2b0e938%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637244713989571165&amp;sdata=d0LysMNmsc%2BSzSkYsZDmE43azU0nmAb%2B1tFHn%2BMNxDg%3D&amp;reserved=0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx