[AMD Public Use]
case CHIP_ARCTURUS:
+ return __get_eeprom_i2c_addr_arct(adev, i2c_addr);
+ break;
This 'break' is not needed. Please remove it.
Regards,
Guchun
From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Zhang,
Hawking
Sent: Tuesday, February 25, 2020 6:42 PM
To: Clements, John <john.cleme...@amd.com>; amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: Add Arcturus D342 page retire support
[AMD Official Use Only - Internal Distribution Only]
Please fix your coding style in the follow if/else code segment by removing the
unnecessary {}. Other than that, the patch is
Reviewed-by: Hawking Zhang <hawking.zh...@amd.com<mailto:hawking.zh...@amd.com>>
+ if (strnstr(atom_ctx->vbios_version,
+ "D342",
+ sizeof(atom_ctx->vbios_version)))
+ {
+ *i2c_addr = EEPROM_I2C_TARGET_ADDR_ARCTURUS_D342;
+ }
+ else
+ {
+ *i2c_addr = EEPROM_I2C_TARGET_ADDR_ARCTURUS;
+ }
Regards,
Hawking
From: Clements, John <john.cleme...@amd.com<mailto:john.cleme...@amd.com>>
Sent: Tuesday, February 25, 2020 17:58
To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>; Zhang,
Hawking <hawking.zh...@amd.com<mailto:hawking.zh...@amd.com>>
Subject: [PATCH] drm/amdgpu: Add Arcturus D342 page retire support
Add support for detecting Arcturus SKU to resolve the correct bad page
retirement EEPROM I2C address.
Thank you,
John Clements
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
