Am 18.02.20 um 09:30 schrieb Huang Rui:
While the current amdgpu doesn't support TMZ, it will return the error if user
mode would like to allocate secure buffer.

Fixes: 17d907c drm/amdgpu: implement TMZ accessor (v3)

v2: we didn't need this checking anymore.

You misunderstood me.


Signed-off-by: Huang Rui <ray.hu...@amd.com>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 5 -----
  1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
index b51a060..5cbc63a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
@@ -235,11 +235,6 @@ int amdgpu_gem_create_ioctl(struct drm_device *dev, void 
*data,
        if (args->in.domains & ~AMDGPU_GEM_DOMAIN_MASK)
                return -EINVAL;
- if (amdgpu_is_tmz(adev) && (flags & AMDGPU_GEM_CREATE_ENCRYPTED)) {
-               DRM_ERROR("Cannot allocate secure buffer since TMZ is 
disabled\n");

Only the error message should be removed, but we still need to test the flag.

E.g. in general we should never log that userspace sends invalid parameters.

Regards,
Christian.

-               return -EINVAL;
-       }
-
        /* create a gem object to contain this object in */
        if (args->in.domains & (AMDGPU_GEM_DOMAIN_GDS |
            AMDGPU_GEM_DOMAIN_GWS | AMDGPU_GEM_DOMAIN_OA)) {

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to