Re: [PATCH] drm/amdgpu/sriov set driver_table address in VF

[Deucher, Alexander]

[AMD Public Use]

Acked-by: Alex Deucher <alexander.deuc...@amd.com>
________________________________
From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Jack Zhang 
<jack.zha...@amd.com>
Sent: Friday, February 7, 2020 4:51 AM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Zhang, Jack (Jian) <jack.zha...@amd.com>
Subject: [PATCH] drm/amdgpu/sriov set driver_table address in VF

With the recent patch to unify VRAM address for driver
table(a83f82e). VF cannot dump table info any more because
SMU_MSG_SetDriverDramAddrHigh/Low were deleted in the
function of smu_update_table.

Therefore, VF also needs to set driver_table address
in smu_hw_init to fix this regression issue.

Signed-off-by: Jack Zhang <jack.zha...@amd.com>
---
 drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c 
b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
index 99ad4dd..b155f04 100644
--- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
@@ -1113,12 +1113,12 @@ static int smu_smc_table_hw_init(struct smu_context 
*smu,
                         return ret;
         }

+       ret = smu_set_driver_table_location(smu);
+       if (ret)
+               return ret;
+
         /* smu_dump_pptable(smu); */
         if (!amdgpu_sriov_vf(adev)) {
-               ret = smu_set_driver_table_location(smu);
-               if (ret)
-                       return ret;
-
                 /*
                  * Copy pptable bo in the vram to smc with SMU MSGs such as
                  * SetDriverDramAddr and TransferTableDram2Smu.
--
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Calexander.deucher%40amd.com%7Caf208aa3ff7b4af7901308d7abb35adb%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637166659148950161&amp;sdata=y56uFDZzrgroC8VLFTQsB8Oe0%2BmNyIoMoMvNrjqhrIs%3D&amp;reserved=0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx